Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve BQ test utils to support JSON in a more simple manner #22942

Merged
merged 7 commits into from
Sep 1, 2022
Merged

Improve BQ test utils to support JSON in a more simple manner #22942

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ee37146
Improve BQ test utils to support JSON in a more simple manner
pabloem Aug 29, 2022
22392eb
Fix storage api path
pabloem Aug 30, 2022
0f7d9c3
fix boolean tests
pabloem Aug 30, 2022
c30f4ed
fixup
pabloem Aug 30, 2022
78a7730
double is representable in JSON
pabloem Aug 30, 2022
7781827
same
pabloem Aug 30, 2022
ac0ad72
Doubles can be represented in JSON as well
pabloem Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix boolean tests
  • Loading branch information
@pabloem
pabloem committed Aug 30, 2022
commit 0f7d9c34b43c8ec4d5b99791b05ae8870cf38f03
12 changes: 6 additions & 6 deletions ...e-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,10 +610,10 @@ public void testToTableRow_flat() {
assertThat(row, hasEntry("time0s_ns", "12:34:00.789876"));
assertThat(row, hasEntry("time0s_0ns", "12:34:00"));
assertThat(row, hasEntry("name", "test"));
assertThat(row, hasEntry("valid", "false"));
assertThat(row, hasEntry("valid", false));
assertThat(row, hasEntry("binary", "ABCD1234"));
assertThat(row, hasEntry("numeric", "123.456"));
assertThat(row, hasEntry("boolean", "true"));
assertThat(row, hasEntry("boolean", true));
assertThat(row, hasEntry("long", "123"));
assertThat(row, hasEntry("double", "123.456"));
}
Expand Down Expand Up @@ -664,10 +664,10 @@ public void testToTableRow_row() {
assertThat(row, hasEntry("time0s_ns", "12:34:00.789876"));
assertThat(row, hasEntry("time0s_0ns", "12:34:00"));
assertThat(row, hasEntry("name", "test"));
assertThat(row, hasEntry("valid", "false"));
assertThat(row, hasEntry("valid", false));
assertThat(row, hasEntry("binary", "ABCD1234"));
assertThat(row, hasEntry("numeric", "123.456"));
assertThat(row, hasEntry("boolean", "true"));
assertThat(row, hasEntry("boolean", true));
assertThat(row, hasEntry("long", "123"));
assertThat(row, hasEntry("double", "123.456"));
}
Expand All @@ -691,10 +691,10 @@ public void testToTableRow_array_row() {
assertThat(row, hasEntry("time0s_ns", "12:34:00.789876"));
assertThat(row, hasEntry("time0s_0ns", "12:34:00"));
assertThat(row, hasEntry("name", "test"));
assertThat(row, hasEntry("valid", "false"));
assertThat(row, hasEntry("valid", false));
assertThat(row, hasEntry("binary", "ABCD1234"));
assertThat(row, hasEntry("numeric", "123.456"));
assertThat(row, hasEntry("boolean", "true"));
assertThat(row, hasEntry("boolean", true));
assertThat(row, hasEntry("long", "123"));
assertThat(row, hasEntry("double", "123.456"));
}
Expand Down