Improve BQ test utils to support JSON in a more simple manner #22942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Thanks for the fix. Could you please providing some context of the change, like what current issue we have using INT32? |
|
thanks @Abacn - I've added an explanation on the top comment of the PR. |
|
Run Java PostCommit |
|
Run Java PostCommit |
|
Retest this please |
|
feels like jenkins is targeting me personally : ) lol |
|
Run Java PreCommit |
|
Run Java_Examples_Dataflow_Java11 PreCommit |
|
uggg these don't repro in my local env |
|
Run Java PostCommit |
|
Run Java_Examples_Dataflow PreCommit |
|
Run Java PreCommit |
|
errors unrelated. Feel free to review @Abacn |
|
Run Java PreCommit |
dedocibula
pushed a commit
to dedocibula/beam
that referenced
this pull request
Sep 15, 2022
…#22942) * Improve BQ test utils to support JSON in a more simple manner * Fix storage api path * fix boolean tests * fixup * double is representable in JSON * same * Doubles can be represented in JSON as well
kkdoon
pushed a commit
to twitter-forks/beam
that referenced
this pull request
Sep 29, 2022
…#22942) * Improve BQ test utils to support JSON in a more simple manner * Fix storage api path * fix boolean tests * fixup * double is representable in JSON * same * Doubles can be represented in JSON as well
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
Oct 17, 2022
…#22942) * Improve BQ test utils to support JSON in a more simple manner * Fix storage api path * fix boolean tests * fixup * double is representable in JSON * same * Doubles can be represented in JSON as well
Abacn
pushed a commit
to Abacn/beam
that referenced
this pull request
Jan 31, 2023
…2926 and apache/beam/apache#22942 in snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigQuery testing utilities (and some prod utilities as well) default to converting individual data values into strings when converting data to JSON-encoded TableRow objects. This makes some testing difficult, as data types can't be recovered properly.
This change ensures that JSON conversion preserves the data type when possible in JSON (boolean, int32, float, double) so that testing and other consumers of TableRow data can expect correct types.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.