Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content #11554

Merged
merged 6 commits into from
May 14, 2020
Merged

[BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content #11554

merged 6 commits into from
May 14, 2020

Conversation

bntnam
Copy link
Contributor

@bntnam bntnam commented Apr 28, 2020 •
edited
Loading

Dear friends,
Our tasks are listed in general as below:

  • Migrated Apache Beam website from Jekyll to Hugo.
  • Configured multilingual support.
  • Developed testing with link-checker.
  • Updated documentation.

For more details, please refer to README.md and CONTRIBUTE.md inside website dir. :)
Best regards!

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status		 Build Status
Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status
Build Status		 Build Status
Build Status		 --- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status		 Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@bntnam
Copy link
Contributor Author

bntnam commented Apr 28, 2020

Hi @pabloem, please take a look! :)

@pabloem
Copy link
Member

pabloem commented Apr 28, 2020

retest this please

@pabloem
Copy link
Member

pabloem commented Apr 28, 2020

(retest this please is a code word to ask jenkins to trigger tests)

@pabloem
Copy link
Member

pabloem commented Apr 28, 2020

Staged website: http://apache-beam-website-pull-requests.storage.googleapis.com/11554/index.html
There's something odd with it. Most internal links don't seem to be working in the staged site. LMK if I can help figure that out.

FYI The RAT PreCommit is related to having Apache License headers in all files. That should be fixed before merging.

@pabloem
Copy link
Member

pabloem commented Apr 28, 2020

retest this please

1 similar comment
@pabloem
Copy link
Member

pabloem commented Apr 28, 2020

retest this please

@bntnam
Copy link
Contributor Author

bntnam commented Apr 28, 2020 •
edited
Loading

@pabloem : Thanks for letting me know. I'll look into it. And, there are conflicts. Probably, it stops you "retest this please". :D
Update: Ok I resoved it!

About the RAT PreCommit, do you know which files missing the Apache License? There are tons of files in the project, so idk which one it is.

@pabloem
Copy link
Member

pabloem commented Apr 28, 2020

retest this please

2 similar comments
@pabloem
Copy link
Member

pabloem commented Apr 28, 2020

retest this please

@pabloem
Copy link
Member

pabloem commented Apr 28, 2020

retest this please

@pabloem
Copy link
Member

pabloem commented Apr 28, 2020

Staging still looks odd: : / - http://apache-beam-website-pull-requests.storage.googleapis.com/11554/index.html

@bntnam
Copy link
Contributor Author

bntnam commented Apr 29, 2020

Hi @pabloem, we made a fix. You could do retest this please once again. 🙂

@pabloem
Copy link
Member

pabloem commented Apr 29, 2020

retest this please

@pabloem
Copy link
Member

pabloem commented Apr 29, 2020

Run RAT PreCommit

@pabloem
Copy link
Member

pabloem commented Apr 29, 2020

Run Website_Stage_GCS PreCommit

@TheNeuralBit
Copy link
Member

It looks like you first made a bunch of commits that added files to the new directory (e.g. ff7ef26) and then made one commit that deleted the entire old directory (ee58199). This means that changes that are effectively just file renames (like all of the blog posts) are not tracked as such, so it looks like a bunch of files were deleted and then re-created - which makes it really hard to review the change.

I think if you just squash all of your commits into one, then git should recognize the files are basically the same, and mark them as renames. More details here: https://stackoverflow.com/questions/433111/how-to-make-git-mark-a-deleted-and-a-new-file-as-a-file-move

@pabloem pabloem mentioned this pull request Apr 30, 2020
Merged
@TheNeuralBit TheNeuralBit mentioned this pull request Apr 30, 2020
Closed
@TheNeuralBit
Copy link
Member

retest this please

1 similar comment
@pabloem
Copy link
Member

pabloem commented Apr 30, 2020

retest this please

@pabloem
Copy link
Member

pabloem commented Apr 30, 2020

I am not famliar with the staging functionality, so I'm not sure what those errors could be from...

@pabloem
Copy link
Member

pabloem commented Apr 30, 2020

staged site: http://apache-beam-website-pull-requests.storage.googleapis.com/11554/index.html

@aaltay
Copy link
Member

aaltay commented May 12, 2020

retest this please

3 similar comments
@aaltay
Copy link
Member

aaltay commented May 12, 2020

retest this please

@aaltay
Copy link
Member

aaltay commented May 12, 2020

retest this please

@aaltay
Copy link
Member

aaltay commented May 12, 2020

retest this please

@aaltay
Copy link
Member

aaltay commented May 13, 2020

retest this please

2 similar comments
@aaltay
Copy link
Member

aaltay commented May 13, 2020

retest this please

@aaltay
Copy link
Member

aaltay commented May 13, 2020

retest this please

@aaltay
Copy link
Member

aaltay commented May 13, 2020

Run Python PreCommit

@aaltay
Copy link
Member

aaltay commented May 13, 2020

Run Java PreCommit

@pabloem
Copy link
Member

pabloem commented May 13, 2020

retest this please

1 similar comment
@aaltay
Copy link
Member

aaltay commented May 14, 2020

retest this please

@kamilwu
Copy link
Contributor

kamilwu commented May 14, 2020

Run Java PreCommit

@kamilwu
Copy link
Contributor

kamilwu commented May 14, 2020

retest this please

@kamilwu
Copy link
Contributor

kamilwu commented May 14, 2020

Run Python2_PVR_Flink PreCommit

1 similar comment
@kamilwu
Copy link
Contributor

kamilwu commented May 14, 2020

Run Python2_PVR_Flink PreCommit

@aaltay
Copy link
Member

aaltay commented May 14, 2020

Before merging, please share a link to the archived copy of the old website.

@pabloem
Copy link
Member

pabloem commented May 14, 2020

Here's a zipfile with the staged website: https://drive.google.com/file/d/1LKL936tBJ79jpjvlL5vC5uYYwTHsWXiJ/view?usp=sharing

This comes from staging PR 11705 (any recent PR without website changes would work).

@pabloem
Copy link
Member

pabloem commented May 14, 2020

I'd think it's worth adding a tag to the commit, marking it as the first commit with hugo-based website.

@pabloem
Copy link
Member

pabloem commented May 14, 2020

(a committer can add this after merging)

@aaltay aaltay merged commit 1d27008 into apache:master May 14, 2020
@pabloem
Copy link
Member

pabloem commented May 14, 2020

I've tagged the commit 1d27008 with the website-to-hugo tag.
fyi @aijamalnk @bntnam et al

yirutang pushed a commit to yirutang/beam that referenced this pull request Jul 23, 2020
@bntnam @yirutang
[BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable lo…
c7a0fa0 
…calization of the site content (apache#11554)

[BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content (apache#11554)

* Moved files from src to www
* Applied changes - Migrated Jekyll to Hugo

Setup Docsy themes
Fixed github_sample
Added Works With logos
Sync new update
Adopted to reviews & Updated content
Excluded website build files
Added Apache License
Docker removed root
Modified test link checker
Latest sync

* Cleaned unused Jekyll files
* Adapted to reviews
* Fixes based on diff script
* Corrected path flink_runner.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertwb robertwb robertwb left review comments

@TheNeuralBit TheNeuralBit TheNeuralBit left review comments

@pabloem pabloem pabloem left review comments

@aaltay aaltay aaltay approved these changes

Assignees
No one assigned
Labels
build docker examples extensions flink infra java runners sql website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bntnam @pabloem @TheNeuralBit @manuzhang @mwalenia @kamilwu @aaltay @robertwb