-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.9 support to Hive #21893
Conversation
I would love this one merged before I release a new wave of providers for Feb |
f2f7f73
to
31d3da8
Compare
I see dropbox/PyHive#380 is still open. What changed to make this viable? |
Yeah, I thought the same initially and commented the same - but I looked closer - see #21891 discussion. Rather than PyHive switching to another implementation (pure-sasl based) cloudera released the I am going to close dropbox/PyHive#380 as soon as we merge this one. |
Closed/Reopened to ACTUALLY run Python 3.9 tests (with |
31d3da8
to
8240de3
Compare
And 🤦 I also removed the skipIfs to actually RUN the tests on Python 3.9 :D |
Ah, so the 0.3 series of sasl supports 3.9, solving our issue. Perhaps it’d be worthwhile to add some additional specifiers to describe this? e.g.
|
Good idea. I prefer not to complicate our setup if not needed sasl is a very specific library and pragmatically speaking anyone installing hive provider on Python 3.9 wll get latest (0.3.1) version installed. But yeah that might be a good idea as there might be some cases where someone has an older version of sasl library installed. Adding it. |
8240de3
to
52795fd
Compare
Added it now @uranusjr ! Thanks for pointing it out ! I actually made it >=3.0.1 as apparently |
52795fd
to
59537ac
Compare
🤦 🤦 🤦 0.3.1 not 3.0.1 @potiuk. Try to copy&paste next time :D |
06b5e10
to
991fc27
Compare
Hive support for Python 3.9 has been removed in apache#15515 but cloudera released new ssl 0.3.1 library version to support it and we should be able to get Hive provider working for Python 3.9 too. Fixes: apache#21891
991fc27
to
4e2c954
Compare
Just rundom "maybe ? " test |
Hive support for Python 3.9 has been removed in #15515 but cloudera
released new ssl 0.3.1 library version to support it and we should
be able to get Hive provider working for Python 3.9 too.
Fixes: #21891
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.