-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AWS RDS operators #20907
Added AWS RDS operators #20907
Conversation
Hi, @dstandish. |
c7888c5
to
9af1954
Compare
9af1954
to
1e1af84
Compare
57ba57c
to
42b0d0f
Compare
Hi sorry for the delay I was out for a bit then catching up on stuff. Anything in particular you need guidance on? Or just it's ready to go and needs review. |
Thanks for helping, @dstandish. I think it's ready for review. Talking about RdsHook (#20642), there are some strange mypy errors that are not caused by my changes. |
ccb7966
to
061da0e
Compare
061da0e
to
c935747
Compare
022ea65
to
e95b0bb
Compare
Methods that are used in tests were implemented by me and available since version |
df40cc2
to
87c99f0
Compare
5fc7b80
to
1c64923
Compare
1c64923
to
7382ba5
Compare
The RdsHook is already merged and |
Added AWS RDS management operators.
Based on: #20642 and #22005
The main issue that I have is how to test it. There are several options to do that:
unittest.mock
, but as I understand Airflow is moving fromunittest
pytest
pytest-mock
librarymoto
library.Unfortunatelymock_rds2
doesn't support operations with clusters, exports, and event subscriptions.I've added these methods and they are available since version
moto>=3.0.2