Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings panel toggle button doesn't expose the associated keyboard shortcut #65310

Closed
2 tasks done
afercia opened this issue Sep 13, 2024 · 0 comments · Fixed by #65322
Closed
2 tasks done

Settings panel toggle button doesn't expose the associated keyboard shortcut #65310

afercia opened this issue Sep 13, 2024 · 0 comments · Fixed by #65322
Assignees
@afercia
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Sep 13, 2024

Description

All buttons that are associated with a keyboard shortcut should visually expose the shortcut in a tooltip.

The Settings panel toggle button doesn't. Only the 'X' close button in the eettings panel does it.

Screenshot:

Screenshot 2024-09-13 at 10 06 37

Step-by-step reproduction instructions

  • Go to the post or site editor.
  • Hover or focus the Settings toggle butotn.
  • Observe the button tooltip text is 'Settings' and doesn't contain the keyboard shortcut.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor labels Sep 13, 2024
@afercia afercia self-assigned this Sep 13, 2024
@afercia afercia mentioned this issue Sep 13, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afercia afercia

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the Settings panel toggle button show its keyboard shortcut in its tooltip WordPress/gutenberg
1 participant
@afercia