From 86d41407ed9358ce50921db5249343841321214f Mon Sep 17 00:00:00 2001 From: Jason Poon Date: Tue, 19 Jun 2018 02:11:57 -0700 Subject: [PATCH] fix: closes #2390. enables remapping using '' in addition to '' --- src/configuration/notation.ts | 2 +- test/configuration/notation.test.ts | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/configuration/notation.ts b/src/configuration/notation.ts index 416558a8804..9e1be2a060b 100644 --- a/src/configuration/notation.ts +++ b/src/configuration/notation.ts @@ -25,7 +25,7 @@ export class Notation { return ' '; } - if (key.toLocaleLowerCase() === '') { + if (key.toLocaleLowerCase() === '' || key.toLocaleLowerCase() === '') { return '\n'; } diff --git a/test/configuration/notation.test.ts b/test/configuration/notation.test.ts index 7772720a9fe..542b486fef5 100644 --- a/test/configuration/notation.test.ts +++ b/test/configuration/notation.test.ts @@ -4,8 +4,8 @@ import { Notation } from '../../src/configuration/notation'; suite('Notation', () => { test('Normalize', () => { - let leaderKey = '//'; - let testCases = { + const leaderKey = '//'; + const testCases = { '': '', 'cTrL+x': '', 'CtRl+y': '', @@ -14,6 +14,8 @@ suite('Notation', () => { eScapE: '', '': '//', LEaDer: '//', + '': '\n', + '': '\n', '': ' ', '': '', };