Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow remappings from mocked configurations during testing. #2732

Closed
regiontog opened this issue Jun 14, 2018 · 0 comments · Fixed by #2733
Closed

Allow remappings from mocked configurations during testing. #2732

regiontog opened this issue Jun 14, 2018 · 0 comments · Fixed by #2733
Labels
kind/enhancement

Comments

@regiontog
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature

Environment:

  • Extension (VsCodeVim) version: 0.12.0
  • VSCode version: 1.24.0
  • OS version: Linux 4.15.12

I'm trying to create a test for long key chords, however the ModeHandler ignores remappings during testing. Now that the configuration is mocked could the ModeHandler respect the remappings? The tests seemed to run fine on my machine with the remappings from #451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't ignore mocked configurations' remaps during testing. regiontog/Vim
2 participants
@jpoon @regiontog