Fix vcs3d failing test

[aashish24]

No description provided.

[durack1]

@aashish24 if this is the same issue as https://open.cdash.org/testDetails.php?test=334149793&build=3808629 - it's DVD3D not VCS3D that's got the problem.

It looks to me like it's a case of continental bounds missing a single point, so the start not returning to the exact end point, closing the polygon.

[alliepiper]

Agreed -- shouldn't the DV3D team be looking at this?

[ThomasMaxwell]

The code that generates the boundaries is in shapeFileReader.getPolyLines in Packages/DV3D/Shapefile.py.

— Tom

From: "Paul J. Durack" <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Monday, May 11, 2015 at 1:51 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Subject: Re: [uvcdat] Fix vcs3d failing test (#1305)

@aashish24https://github.com/aashish24 if this is the same issue as https://open.cdash.org/testDetails.php?test=334149793&build=3808629 - it's DVD3D not VCS3D that's got the problem.

It looks to me like it's a case of continental bounds missing a single point, so the start not returning to the exact end point, closing the polygon.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1305#issuecomment-100996736.

[chaosphere2112]

If I'm reading the file that @ThomasMaxwell pointed at correctly, the continents are defined in a GIS shapefile, which is then rendered using vtkPolyData. I'm guessing it's an OpenGL or VTK quirk, not an issue with DV3D; it works perfectly fine on my mac, so it must be something platform dependent.

[chaosphere2112]

@dlonie Looks like the shapefile is converted to VTK here:

https://github.com/UV-CDAT/uvcdat/blob/3f99c8e3ab0278e6f9b7c6083c3396c7edd61c54/Packages/DV3D/Shapefile.py#L1136-L1224

[aashish24]

@dlonie @ThomasMaxwell is busy with other tasks and we discussed that vcs3D (visualization related) changes will be taken care by you and me (obviously with @ThomasMaxwell's help).

[doutriaux1]

and @chaosphere2112 we also discussed that @aashish24 and @dlonie are very busy and wouldn't want you guys charging your precious time on things we an also fix 😉

[aashish24]

@doutriaux1 we are never too busy for you 👍

[doutriaux1]

Awwww... You're too nice 😉 Anyhow you do run out of money though 😜

[aashish24]

I think we all do -:)