fix: remove currentBridge #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After double-checking, this issue seems tightly connected to using |
|
@WoLewicki thanks a lot :) |
wcandillon
approved these changes
Jul 31, 2024
|
Should I do something to push it forward? |
|
Will release it this morning :) |
|
🎉 This issue has been resolved in version 1.3.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR changing the occurence of
currentBridgeto properly retrievedself.bridge. If not applying this, onbridgelessmode the wrong instance of bridge is acquired, leading to adding JSI bindings to wrong runtime. It is possible that it only occurs when usingexpoin the project. See https://github.com/natedevxyz/rn-skia-test for reproduction.