Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1019: httputil.ClientConn has been deprecated since Go 1.0: Use Client or Transport in package net/http instead. #919

Open
EtienneM opened this issue Mar 24, 2023 · 1 comment
Labels

Comments

@EtienneM
Copy link
Member

apps/run.go:350:12: SA1019: httputil.ClientConn has been deprecated since Go 1.0: Use Client or Transport in package net/http instead. (staticcheck)                                          
        var conn *httputil.ClientConn                                                                                                                                                         
                  ^                                                                            
apps/run.go:356:10: SA1019: httputil.NewClientConn has been deprecated since Go 1.0: Use the Client or Transport in package net/http instead. (staticcheck)                                   
                conn = httputil.NewClientConn(tlsConn, nil)                                                                                                                                   
                       ^                                                                                                                                                                      
apps/run.go:358:10: SA1019: httputil.NewClientConn has been deprecated since Go 1.0: Use the Client or Transport in package net/http instead. (staticcheck)                                   
                conn = httputil.NewClientConn(dial, nil)                                                                                                                                      
@EtienneM EtienneM added the low label Mar 24, 2023
@EtienneM
Copy link
Member Author

I tried to find a solution but didn't succeed. There is no more HTTP client hijack in Go (golang/go#28030). Hence we need to figure out another way to make the underlying TCP connection bidirectional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants