Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRAVIS: Set coverage branch as linux. #490

Merged
merged 1 commit into from
Jul 4, 2019
Merged

TRAVIS: Set coverage branch as linux. #490

merged 1 commit into from
Jul 4, 2019

Conversation

shizejin
Copy link
Member

@shizejin shizejin commented Jul 4, 2019

Only submit coverage reports from the linux build job.

@mmcky
Copy link
Contributor

mmcky commented Jul 4, 2019

thanks @shizejin. Do you find coveralls not working on an other platform?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.95% when pulling 22c4831 on shizejin:coverage_branch into 2438403 on QuantEcon:master.

@shizejin shizejin mentioned this pull request Jul 4, 2019
Merged
@shizejin
Copy link
Member Author

shizejin commented Jul 4, 2019

Hi @mmcky, coveralls is working in both linux and osx, but I found that submitting coverage reports from both platforms causes inconsistent updates (see discussion #489), and I guess this PR could solve this problem.

@mmcky
Copy link
Contributor

mmcky commented Jul 4, 2019

I see. thanks @shizejin happy to accept coverage reports from linux builds.

@mmcky mmcky merged commit a787600 into QuantEcon:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shizejin @mmcky @coveralls