Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of QuantEcon.py - November #410

Closed
6 tasks done
mmcky opened this issue May 20, 2018 · 3 comments · Fixed by #515
Closed
6 tasks done

Cleanup of QuantEcon.py - November #410

mmcky opened this issue May 20, 2018 · 3 comments · Fixed by #515
Assignees

Comments

@mmcky
Copy link
Contributor

mmcky commented May 20, 2018

I would like to tidy up QuantEcon.py (thanks @oyamad for kicking this off). Please add any items re: maintenance of the repo below. I will then review this first week of November.

@mmcky mmcky added the discuss label May 20, 2018
@oyamad
Copy link
Member

oyamad commented May 28, 2018

  • Remove unused data files from data

@oyamad
Copy link
Member

oyamad commented May 28, 2018

  • Test files other than those under quantecon/tests are not installed. For example, look into site-packages/quantecon/markov on your machine.
  • Possibly related to the above and to the role of pip-requirements.txt, listing manually subdirectories here

    QuantEcon.py/setup.py

    Lines 97 to 104 in 35f41b1

    packages=['quantecon',
    'quantecon.game_theory',
    'quantecon.game_theory.game_generators',
    'quantecon.markov',
    'quantecon.random',
    'quantecon.tests',
    'quantecon.util',
    ],
    does not seem really clever. Would packages=find_packages() work?

Thanks @oyamad I have updated to use setuptools (#515) and hopefully that will solve this issue.

@mmcky mmcky changed the title Cleanup of QuantEcon.py - June Cleanup of QuantEcon.py - November Nov 4, 2019
@mmcky mmcky removed the discuss label Nov 4, 2019
@mmcky mmcky self-assigned this Nov 4, 2019
@mmcky
Copy link
Contributor Author

mmcky commented Nov 4, 2019

  • update year in LICENSE.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants