Remove CARGO_HOME from docker env var
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariocurr
changed the title
CARGO_HOME from passed env varCARGO_HOME from docker env var
|
Since dtolnay/rust-toolchain#108 got merged, I guess this PR is very useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm Dario.
Using this action, I encountered a strange error. Then I realized that the problem was that I had set the
CARGO_HOMEenvironment variable in a previous step and that this variable was passed as-eargument to thedocker runcommand.So, when trying to use the
rustupcommand the wrongPATHwas used instead of the immediately previous one installed.I believe this is a dangerous misconfiguration that may lead to an unusable action for some users.
For this reason I would explicitly exclude some variables such as
CARGO_HOMEthat should not be passed.