From f7dc1f1299cee06e20b65f8e457d74bf1cb6f76f Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Wed, 8 Dec 2021 13:40:00 +0100 Subject: [PATCH] fix monaco-graphql bug with `_cacheSchemas()` (#2105) Introduced this slight bug with major impact to `monaco-graphql` last night whilst moving things around. Make sure `_cacheSchemas()` is always called on init in the `LanguageService` --- .changeset/fuzzy-ants-float.md | 5 +++++ packages/monaco-graphql/src/LanguageService.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/fuzzy-ants-float.md diff --git a/.changeset/fuzzy-ants-float.md b/.changeset/fuzzy-ants-float.md new file mode 100644 index 00000000000..11051f62e6d --- /dev/null +++ b/.changeset/fuzzy-ants-float.md @@ -0,0 +1,5 @@ +--- +'monaco-graphql': patch +--- + +Fix a bug where `_cacheSchemas()` was not being called by the language service diff --git a/packages/monaco-graphql/src/LanguageService.ts b/packages/monaco-graphql/src/LanguageService.ts index c80d541b4c9..0feb8d842b5 100644 --- a/packages/monaco-graphql/src/LanguageService.ts +++ b/packages/monaco-graphql/src/LanguageService.ts @@ -64,10 +64,10 @@ export class LanguageService { this._schemaLoader = defaultSchemaLoader; if (schemas) { this._schemas = schemas; + this._cacheSchemas(); } if (parser) { this._parser = parser; - this._cacheSchemas(); } if (parseOptions) {