Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Increase the memory capacity and add RVV in the dual config #319

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

xiaokamikami
Copy link
Contributor

Since the V extension implementation is enabled by default in Xiangshan, RVV is enabled by default.
At the same time, in order to support the operation of checkpoint on multi-core, the memory and single-core config are set to the same configuration (8G MMAP).

@xiaokamikami xiaokamikami changed the title config: Increase the memory capacity in the dual configuration config: Increase the memory capacity and add RVV in the dual config Apr 28, 2024
@Ziyue-Zhang Ziyue-Zhang merged commit 8366f6a into OpenXiangShan:master Apr 28, 2024
4 checks passed
@poemonsense
Copy link
Member

@Ziyue-Zhang Which configs are expected to be used for xiangshan master? In #317, @huxuan0307 is using kunminghu config. Current XiangShan maintainers should discuss and reach an agreement on this.

@Ziyue-Zhang
Copy link
Contributor

@Ziyue-Zhang Which configs are expected to be used for xiangshan master? In #317, @huxuan0307 is using kunminghu config. Current XiangShan maintainers should discuss and reach an agreement on this.

I think use configs/riscv64-dual-xs-ref_defconfig which updated in this PR is better. I checked the diffrence between riscv64-dual-xs-ref_defconfig and riscv64-dual-xs-kunminghu-ref_defconfig, only found CONFIG_MSIZE and CONFIG_USE_MMAP are different. Config riscv64-dual-xs-kunminghu-ref_defconfig only updated the setting of rvv and rvh. This PR not only updated these, also updated CONFIG_MSIZE and CONFIG_USE_MMAP with value in riscv64-xs-ref_defconfig.

@poemonsense
Copy link
Member

@Ziyue-Zhang Which configs are expected to be used for xiangshan master? In #317, @huxuan0307 is using kunminghu config. Current XiangShan maintainers should discuss and reach an agreement on this.

I think use configs/riscv64-dual-xs-ref_defconfig which updated in this PR is better. I checked the diffrence between riscv64-dual-xs-ref_defconfig and riscv64-dual-xs-kunminghu-ref_defconfig, only found CONFIG_MSIZE and CONFIG_USE_MMAP are different. Config riscv64-dual-xs-kunminghu-ref_defconfig only updated the setting of rvv and rvh. This PR not only updated these, also updated CONFIG_MSIZE and CONFIG_USE_MMAP with value in riscv64-xs-ref_defconfig.

So close that PR?

@Ziyue-Zhang
Copy link
Contributor

@Ziyue-Zhang Which configs are expected to be used for xiangshan master? In #317, @huxuan0307 is using kunminghu config. Current XiangShan maintainers should discuss and reach an agreement on this.

I think use configs/riscv64-dual-xs-ref_defconfig which updated in this PR is better. I checked the diffrence between riscv64-dual-xs-ref_defconfig and riscv64-dual-xs-kunminghu-ref_defconfig, only found CONFIG_MSIZE and CONFIG_USE_MMAP are different. Config riscv64-dual-xs-kunminghu-ref_defconfig only updated the setting of rvv and rvh. This PR not only updated these, also updated CONFIG_MSIZE and CONFIG_USE_MMAP with value in riscv64-xs-ref_defconfig.

So close that PR?

That PR also update single-core config. Can I use that PR update riscv64-xs_defconfig and riscv64-xs-ref_defconfig, but not add new kunminghu config? Too many configs is difficult for us to mantain.

@poemonsense
Copy link
Member

That PR also update single-core config. Can I use that PR update riscv64-xs_defconfig and riscv64-xs-ref_defconfig, but not add new kunminghu config? Too many configs is difficult for us to mantain.

Sure. It's great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants