-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vfio-plugin: refactor and fix bugs in enumeration #1805
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move reading of mmio until after pci attributes match filters.
* fix use of open_vfio_pair so that it is called only when a VF has a PF physfn and that device is bound to the vfio-pci driver * read afu_id for BAR0 when treating a whole device as an accelerator
anandaravuri
previously approved these changes
Jan 19, 2021
tswhison
previously approved these changes
Jan 19, 2021
plugins/vfio/opae_vfio.c
Outdated
void free_token_list(vfio_token *tokens) | ||
{ | ||
while (tokens) { | ||
vfio_token *t = tokens;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/;;/;/ :)
…OPAE/opae-sdk into rrojo/vfio_plugin_refactor_enum
anandaravuri
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOW, given a specific PCIe address (segment, bus, device, function), the mmio space will be read only when the PCIe address is
set in the filter and it matches a device.
physfn AND that device is bound to the vfio-pci driver.