Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix versioneer compat with py312 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix versioneer compat with py312 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
MNT: change from using SafeConfigParser to ConfigParser 
SafeConfigParser has been deprecated since Python 3.2 and will
be removed in py312.

python/cpython#28292
https://bugs.python.org/issue45173
python/cpython#89336
  • Loading branch information
@tacaswell
tacaswell committed Jun 22, 2022
commit e19a682a461f633a9b4dab33a6247ade0cb1781f
5 changes: 2 additions & 3 deletions versioneer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,9 +339,8 @@ def get_config_from_root(root):
# configparser.NoOptionError (if it lacks "VCS="). See the docstring at
# the top of versioneer.py for instructions on writing your setup.cfg .
setup_cfg = os.path.join(root, "setup.cfg")
parser = configparser.SafeConfigParser()
with open(setup_cfg, "r") as f:
parser.readfp(f)
parser = configparser.ConfigParser()
parser.read(setup_cfg)
VCS = parser.get("versioneer", "VCS") # mandatory

def get(parser, name):
Expand Down