Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复wd-upload 在小程序中关闭图片偏移的情况 #576

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

hzbnb
Copy link
Contributor

@hzbnb hzbnb commented Sep 4, 2024

修复wd-upload 在小程序中关闭图片偏移的情况

🤔 这个 PR 的性质是?(至少选择一个)

  • [ x] 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

改动很小 我就不提Issue了 大佬有时间看下

wd-upload组件 在小程序中关闭图标向下偏移 目前没有发现样式覆盖 只引入了tailwind 没有冲突
检查元素发现在 .wd-upload__close 类中没有 line-height (行高) 这个属性 加上
line-height: var(--wot-upload-close-icon-size, 16px); 后会发正常 下面是图片

6edcc5a3cd697cd7eb077abd64153d7
修改之后
image

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • [x ] 文档已补充或无须补充
  • [x ] 代码演示已提供或无须提供
  • [ x] TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 样式更新
    • 调整了上传组件的样式,优化了上传关闭图标的垂直对齐,提升了视觉效果。
  • 文档更新
    • 更新了上传组件文档中的函数参数,统一了文件处理的参数命名,提高了代码可读性和一致性。

修复wd-upload 在小程序中关闭图片偏移的情况
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 9:20am

Copy link

coderabbitai bot commented Sep 4, 2024

Walkthrough

此次更改主要涉及在 wd-upload 组件的样式表中新增 line-height 属性,以确保上传关闭图标的垂直对齐与其尺寸一致。此属性的值与变量 $-upload-close-icon-size 相匹配。此外,docs/component/upload.md 文件中对多个函数的参数进行了重命名,从 { files } 改为 { fileList },以提高代码的一致性和可读性。

Changes

文件路径 变更摘要
src/uni_modules/wot-design-uni/components/wd-upload/index.scss 新增 line-height 属性以匹配上传关闭图标的大小,添加文件末尾换行符。
docs/component/upload.md handleChangebeforeChoose 函数的参数从 { files }file 改为 { fileList },以统一参数结构。

Poem

在草地上跳跃的小兔子,
上传图标变得更美丽,
行高调整如春风,
让每个细节都闪亮如星,
感谢这小小的变化,
让生活更添乐趣与欢喜! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for wot-design-uni ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cae38f1
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/66d8261d03a87700080af833
😎 Deploy Preview https://deploy-preview-576--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hzbnb
Copy link
Contributor Author

hzbnb commented Sep 4, 2024

只在.wd-upload__close 类 中添加了一个属性
image

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 049f0bf and 20316f0.

Files selected for processing (1)
  • src/uni_modules/wot-design-uni/components/wd-upload/index.scss (2 hunks)
Files skipped from review due to trivial changes (1)
  • src/uni_modules/wot-design-uni/components/wd-upload/index.scss

@hzbnb
Copy link
Contributor Author

hzbnb commented Sep 4, 2024

又修改了 文档上的几个错误

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 20316f0 and cae38f1.

Files selected for processing (1)
  • docs/component/upload.md (9 hunks)
Additional comments not posted (10)
docs/component/upload.md (10)

138-139: 代码更改已批准。

函数签名已更新为解构 fileList 而不是 files,与 AI 生成的摘要一致。


181-182: 代码更改已批准。

函数签名已更新为解构 fileList 而不是 files,与 AI 生成的摘要一致。


225-226: 代码更改已批准。

函数签名已更新为解构 fileList 而不是 files,与 AI 生成的摘要一致。


Line range hint 254-269: 代码更改已批准。

函数签名已更新为接受包含 fileList 的对象,而不是 file,与 AI 生成的摘要一致。


446-447: 代码更改已批准。

函数签名已更新为解构 fileList 而不是 files,与 AI 生成的摘要一致。


464-465: 代码更改已批准。

函数签名已更新为解构 fileList 而不是 files,与 AI 生成的摘要一致。


482-483: 代码更改已批准。

函数签名已更新为解构 fileList 而不是 files,与 AI 生成的摘要一致。


500-501: 代码更改已批准。

函数签名已更新为解构 fileList 而不是 files,与 AI 生成的摘要一致。


Line range hint 1-1:


Line range hint 3-3:

@Moonofweisheng Moonofweisheng merged commit feb64ea into Moonofweisheng:master Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants