Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 wd-textarea组件maxlength限制长度无效 #558

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

zqran
Copy link
Contributor

@zqran zqran commented Aug 25, 2024

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

问题描述:在 form 表单中使用 textarea 组件,并设置了 maxlength 属性时,textarea 的文本长度第一次渲染正常,从第二次开始 maxlength 的限制会失效,导致,整个文本内容都被渲染出来。

问题复现:

11.mp4

💡 需求背景和解决方案

// 当前文本域文字长度
const currentLength = computed(() => {
  // 当前长度,每次都应该通过 `formatValue` 来格式化
  return String(formatValue(props.modelValue) || '').length
})

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • Bug Fixes
    • 修复了文本区域长度计算不准确的问题,通过引入格式化逻辑来确保文本值的准确性。

Copy link

netlify bot commented Aug 25, 2024

Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit 614c3da
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/66ca94c6b0197c0008d671ce
😎 Deploy Preview https://deploy-preview-558--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Aug 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 2:21am

Copy link

coderabbitai bot commented Aug 25, 2024

Walkthrough

此次更改涉及 wd-textarea.vue 组件中 currentLength 计算属性的修改。计算文本区域值长度的方式被更新,从直接使用 props.modelValue,改为使用 formatValue 函数,以确保在计算长度之前对值进行适当处理,从而提高计算的准确性。

Changes

文件 更改摘要
src/uni_modules/wot-design-uni/components/wd-textarea/wd-textarea.vue 更新 currentLength 计算属性以使用 formatValue 函数计算文本区域值的长度。

Poem

🐰 在文本框里轻轻跳,
长度不再有烦恼。
格式化,让它更美,
计算准确心情好!
哦,文本如花绽放,
快乐写作不停放。 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between febe730 and 614c3da.

Files selected for processing (1)
  • src/uni_modules/wot-design-uni/components/wd-textarea/wd-textarea.vue (1 hunks)
Additional comments not posted (1)
src/uni_modules/wot-design-uni/components/wd-textarea/wd-textarea.vue (1)

172-172: 优化 currentLength 计算属性的实现

通过使用 formatValue 函数处理 props.modelValue,确保在计算长度之前对值进行适当的格式化,这有助于提高计算的准确性和组件的健壮性。

@Moonofweisheng Moonofweisheng merged commit 4b1b237 into Moonofweisheng:master Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants