Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 img 图片组件click事件增加mouseEvent参数 #539

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

git-lt
Copy link
Contributor

@git-lt git-lt commented Aug 20, 2024

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

方便用户取消图片点击的事件冒泡
解决img组件放在卡片上,给图片添加点击事件时,会触发卡片的点击事件

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 文档更新

    • 修改了图像组件中 click 事件的描述,增加了事件参数的类型签名,提升了事件预期行为的清晰度和类型安全性。
  • 功能增强

    • wd-img 组件中更新了事件发射逻辑,明确了可发射的事件类型,改善了事件处理机制,确保发射的事件携带适当的事件数据。

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit 03dfc05
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/66c43b9e81669d00089f61a4
😎 Deploy Preview https://deploy-preview-539--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 6:47am

Copy link

coderabbitai bot commented Aug 20, 2024

Walkthrough

此次更改主要集中在改进 mini-program 中图像组件的事件处理逻辑。文档更新了 click 事件的类型签名,增强了开发者的类型安全性。同时,组件内的 emit 函数和事件处理函数也进行了重构,以明确声明可以发射的事件及其对应的类型,提升了事件处理的清晰度与安全性。

Changes

文件路径 更改摘要
docs/component/img.md 更新 click 事件的类型签名,从简单的占位符改为 (event: MouseEvent) => void,提高了类型安全性。
src/.../wd-img/wd-img.vue 修改 emit 函数以使用 TypeScript 的泛型,明确可发射事件及其类型;更新 handleClick 接受 MouseEvent 类型参数。

Poem

在兔子耳边轻轻说,
事件更新真不错!
鼠标点击更清晰,
类型安全乐无穷。
让我们一起欢呼,
编码旅途更精彩! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between febe730 and 03dfc05.

Files selected for processing (2)
  • docs/component/img.md (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-img/wd-img.vue (2 hunks)
Additional comments not posted (3)
src/uni_modules/wot-design-uni/components/wd-img/wd-img.vue (2)

33-37: 改进事件类型安全性

通过使用 TypeScript 泛型定义事件类型,增强了类型安全性和代码的清晰度。这是一个很好的实践。


64-70: 改进点击事件处理

handleClick 函数现在接受 MouseEvent 参数,并传递给 emit 函数。此更改提高了对事件传播的控制,符合 PR 的目标。

建议检查代码库中是否还有其他需要类似更改的地方。

docs/component/img.md (1)

129-129: 更新点击事件文档

文档中 click 事件的类型签名更新为 (event: MouseEvent) => void,提高了开发者使用该事件时的类型安全性和清晰度。

@Moonofweisheng Moonofweisheng merged commit 4983f48 into Moonofweisheng:master Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants