Add isChildOptional() method #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1070 +/- ##
==========================================
- Coverage 94.72% 94.71% -0.01%
==========================================
Files 191 191
Lines 47671 47674 +3
==========================================
Hits 45154 45154
- Misses 2517 2520 +3
Continue to review full report in Codecov by Sentry.
|
sgizler
force-pushed
the
isChildNotNullable
branch
from
aff4031
to
e150a49
Compare
Add method for determining whether child at given index is wrapped in not_null<>. Rationale: Passing child that is wrapped in not_null to SyntaxRewriter::remove(), results in failing not_null assertion. When you remove quite a lot arbitrary nodes it gets cumbersome to avoid this issue "manually". Thanks to this isChildOptional(), one can re-implement visit/visitDefault methods to pass handler information that node must not be removed.
sgizler
force-pushed
the
isChildNotNullable
branch
from
e150a49
to
e2bf8e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method for determining whether child at given index is wrapped in
not_null<>.Rationale:
Passing child that is wrapped in
not_nulltoSyntaxRewriter::remove(), results in failing not_null assertion.When you remove quite a lot arbitrary nodes it gets cumbersome to avoid this issue "manually".
Thanks to this
isChildOptional(), one can re-implementvisit/visitDefaultmethods to pass handler information that node must not be removed.