Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Benchmark Script] Optimise #28

Merged
merged 2 commits into from
Mar 30, 2022
Merged

[Benchmark Script] Optimise #28

merged 2 commits into from
Mar 30, 2022

Conversation

Mariosyian
Copy link
Owner

@Mariosyian Mariosyian commented Mar 30, 2022

Updates benchmark script to alleviate the user from remembering to hardcode their algorithm or language name in too many places. This should improve the user experience and reduce the risk of user error.

  • Updates 💯
    • Update usage profiler conditions and score calculation.
    • Update java compilation steps to create and run a .jar file.
    • Update .gitignore to exclude .jar files from version control.
    • Remove ls method of filtering directories with the more conventional find command.
    • Add regex check for language-alphanumeric directory name structure.
    • Remove hard-coded languages/algorithms lists.
  • Bugs 🐞
  • Miscellanous
    • Add new exit code.
    • Convert local variable names to lowercase and constants to uppercase.
    • Update some functions based on shellcheck conventions. Some as most of the shellcheck conventions seemed to break some of my things, and/or were annoying, or simply seemed meaningless (i.e. not add to performance, or safeguard against errors).

- Add new exit code.
- Remove hard-coded languages/algorithms lists.
- Update some functions based on shellcheck conventions https://github.com/koalaman/shellcheck.
- Convert local variable names to lowercase and constants to uppercase.
- Update usage profiler conditions and score calculation.
- Remove ls method of filtering directories with the more conventional find command.
- Update java compilation steps to create and run a .jar file.
- Add regex check for <language>-<alphanumeric> directory name structure.
- Update python black version due to ImportError.
Copy link
Owner Author

@Mariosyian Mariosyian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎺🎉

@Mariosyian Mariosyian merged commit 7b7af86 into main-dev Mar 30, 2022
@Mariosyian Mariosyian deleted the bugs branch March 30, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant