Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix byte count and delay when writing on serial #489

Merged
merged 3 commits into from
May 27, 2024

Conversation

houkhouk
Copy link

@houkhouk houkhouk commented May 24, 2024

By submiting this PR, you agree with the associated license MIT) and with our Contributor License Agreement (CLA).

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please follow these steps:

  • Ensure that this PR is not a duplicate.

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.

PR Description section

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.

  • fix byte count verification and add delay when sending through serial link in native HAL

WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@houkhouk
Copy link
Author

Assert problem still encountered, PR closed until further fix

@houkhouk houkhouk reopened this May 27, 2024
@houkhouk
Copy link
Author

Ok it's fine. The assert I was getting was due to an odd set-up between the gate, the robus translator and the services. After rebooting everyone, it works.

@nicolas-rabault nicolas-rabault self-requested a review May 27, 2024 12:29
@nicolas-rabault nicolas-rabault added this to the 3.1.0 milestone May 27, 2024
@nicolas-rabault nicolas-rabault mentioned this pull request May 27, 2024
8 tasks
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nicolas-rabault nicolas-rabault merged commit 20c75ee into Luos-io:rc_3.1.0 May 27, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants