Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhoSim Instrumental Configuration does not run #231

Closed
danielsf opened this issue Jul 25, 2018 · 3 comments
Closed

PhoSim Instrumental Configuration does not run #231

danielsf opened this issue Jul 25, 2018 · 3 comments

Comments

@danielsf
Copy link
Contributor

It cannot find "segmentation.txt"

@cwwalter @slosar

@cwwalter
Copy link
Member

So, I wrote this notebook as a utility for people who are doing work on production. The idea was if you had a segmentation.txt file from some version of PhoSim, you could use it to explore what was inside to extract x-talk values etc.

Later, the tutorial notebooks were added to the Notebook directory along with the auto-run output etc.

I was going to suggest we make a subdirectory structure for tutorials, utilities etc and separate them. But in the discussion in #238 by @yymao and @jchiang87 etc it looks like we will be splitting into at least a DC2 production and analysis repo. I suggest this one stay here and not be part of an auto build system. In the mean time, I can also add some text to the cell pointing out you should use your own segmentation.txt file. I'm wary of adding code to automatically fetch one, or check one in, since people might look at different versions than they really need.

@cwwalter
Copy link
Member

OK. I added the following information to the start of the notebook:

This notebook is used to explore PhoSim segmentation.txt file.  This
file contains information on items like sensor position, read noise
characteristics, x-talk values etc.  Using the functions in this
notebook you can explore or extract the values yourself.  This is
useful to (for example) see the x-talk values for a particular sensor
presented in an easily digestible table format.

You can find this file in the PhoSim instruments directory.  So for example in:

phosim_release/data/lsst

You can drill down to the latest release version on the bitbucket site here:

https://bitbucket.org/phosim/phosim_release/src

I couldn't see how to make a link to a actual file on bitbucket which wasn't tied to a a particular commit so I gave the top of the tree instead.

Closing this issue, but feel free to re-open for further discussion or changes.

@yymao
Copy link
Member

yymao commented Jul 29, 2018

Yes, I agree that if we split into DC2-production and DC2-analysis then Chris' notebook should stay in DC2-production, and that would reduce the potential confusion that a general DC2 user might have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants