Make sure sub-graph-specific code is encapsulated in Python submodules #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were overriding the original, non-sub-graph implementations.
graham63
pushed a commit
to graham63/lbann
that referenced
this pull request
Jan 12, 2022
LLNL#2026) We were overriding the original, non-sub-graph implementations.
This was referenced Jan 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By importing sub-graph code directly into our base Python submodules (
lbann.modules,lbann.models), we were overwriting the non-sub-graph implementations of multi-head attention and Transformer. Forcing the user to loadlbann.modules.subgraphorlbann.models.subgraphseems appropriate since this is an advanced, experimental feature.No new Bamboo failures. Pinging @aj-prime and @tnat410.