Fix changes that should not have been in #2020 #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know how or why these changes happened? But basically, the trailing return type (whose namespace resolution depends on being AFTER the function name opens the scope) moved to the front of the prototype but did not have namespaces added. I like it the other way better, so I just restored that.
graham63
pushed a commit
to graham63/lbann
that referenced
this pull request
Jan 12, 2022
I don't know how or why these changes happened? But basically, the trailing return type (whose namespace resolution depends on being AFTER the function name opens the scope) moved to the front of the prototype but did not have namespaces added. I like it the other way better, so I just restored that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how or why these changes happened? But basically, the trailing return type (whose namespace resolution depends on being AFTER the function name opens the scope) moved to the front of the prototype but did not have namespaces added. I like it the other way better, so I just restored that.