Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set the search name for Cereal to be all lowercase. #2012

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Explicitly set the search name for Cereal to be all lowercase. #2012

merged 1 commit into from
Nov 22, 2021

Conversation

benson31
Copy link
Collaborator

I haven't had issues, but this should be correct. Closes #2011.

mrwyattii
mrwyattii approved these changes Nov 22, 2021
View reviewed changes
Copy link
Collaborator

@mrwyattii mrwyattii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benson31 benson31 merged commit 36daf09 into LLNL:develop Nov 22, 2021
@benson31 benson31 deleted the patch-cmake-for-issue-2011_test branch November 22, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrwyattii mrwyattii mrwyattii approved these changes

@timmoon10 timmoon10 Awaiting requested review from timmoon10

@bvanessen bvanessen Awaiting requested review from bvanessen

Assignees
No one assigned
Labels
bug build review requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cereal isn't found because cmake should be looking for 'cereal', not 'CEREAL'
2 participants
@benson31 @mrwyattii