Adding integration tests for the JAG MACC models #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvanessen
force-pushed
the
add_jag_integration_test
branch
from
a025ab6
to
8874aae
Compare
timmoon10
approved these changes
Nov 18, 2021
WAE. Moved the MACC model definitions to MACC network architecture definitions. Created a MACC trainable model function to allow the JAG application to have a single definition of the trainable WAE model that is suitable for both application and testing use cases.
model definition into a separate file for testing. Renamed the MACC models file.
named data fields.
bvanessen
force-pushed
the
add_jag_integration_test
branch
from
4646dd9
to
64f22e6
Compare
graham63
pushed a commit
to graham63/lbann
that referenced
this pull request
Jan 12, 2022
* Added an integration test for the JAG MACC WAE model to pre-train the WAE. Moved the MACC model definitions to MACC network architecture definitions. Created a MACC trainable model function to allow the JAG application to have a single definition of the trainable WAE model that is suitable for both application and testing use cases. * Updated the train_macc_surrogate application to have an integrated test. * Added an integration test for the older JAG model. Refactored the model definition into a separate file for testing. Renamed the MACC models file. * Renamed jag_trainable_models to jag_models. * Removed override of the get_linearized_size in the JAG data reader for named data fields. * Tweaked reconstruction ranges for lassen * Corrected the output cycle loss target values * Fixed expected run times on pascal * Fixing up baseline bamboo tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an integration test for the JAG MACC WAE model to pre-train the
WAE. Moved the MACC model definitions to MACC network architecture
definitions. Created a MACC trainable model function to allow the JAG
application to have a single definition of the trainable WAE model
that is suitable for both application and testing use cases.