add 'enabled' flag for Build Scans #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub can't have default environment variables with dots `.` in them, so defining the build scan server URL in all actions would have to be manually done for each GitHub action. That's annoying and is work to maintain. Instead, this PR adds a 'build.scan.enabled' flag that defaults to 'true' on CI.
IgnatBeresnev
approved these changes
Jan 22, 2024
whyoleg
approved these changes
Jan 22, 2024
adam-enko
added
the
infrastructure
Tapchicoma
approved these changes
Jan 23, 2024
vmishenev
pushed a commit
that referenced
this pull request
Mar 20, 2024
* add 'enabled' flag for Build Scans GitHub can't have default environment variables with dots `.` in them, so defining the build scan server URL in all actions would have to be manually done for each GitHub action. That's annoying and is work to maintain. Instead, this PR adds a 'build.scan.enabled' flag that defaults to 'true' on CI. * fix overridden name not overriding * give GitHub Build Scans a 'GitHub' name * remove old comment about buildScanUrl opt out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to opt GitHub into the Build Scans by default. Currently that's done by adding the build scan URL variable, which in GitHub would be done by adding an environment variable
ORG_GRADLE_PROJECT_org.jetbrains.dokka.build.scan.url=https://ge.jetbrains.com/.But GitHub can't have default environment variables with dots
.in them, so defining the build scan server URL in all actions would have to be manually done for each GitHub action. That's annoying and is work to maintain.Instead, this PR adds a 'build.scan.enabled' flag that defaults to 'true' on CI.
Additionally, some minor tweaks: