Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed style of go to top button #3411

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

berezinant
Copy link
Contributor

fixes #3260

After

image

Before

image

Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally OK with the template/style changes, but let's merge it after 1.9.20 code freeze (the end of this week). There will be breaking html/css changes in 2.0 anyway, so it makes sense to batch them

@IgnatBeresnev IgnatBeresnev linked an issue Dec 19, 2023 that may be closed by this pull request
@berezinant berezinant force-pushed the fix-3260-footer-button branch 3 times, most recently from 95eb28a to 8e81b8e Compare January 15, 2024 14:18
@berezinant berezinant merged commit acb16bf into master Jan 16, 2024
12 checks passed
vmishenev pushed a commit that referenced this pull request Mar 20, 2024
* fix: fixed style of go to top button

* test: updated tests for footer

* fix: simplified markup for external link icon #3260
@berezinant berezinant deleted the fix-3260-footer-button branch August 6, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer has an odd shaped button on Desktop Footer button implementation issue
3 participants