Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use info level for progress in Dokka Gradle plugin #2915

Closed
wants to merge 1 commit into from

Conversation

eirnym
Copy link

@eirnym eirnym commented Mar 12, 2023

fixes #1894

Level for progress set to info. See the issue for more details

@IgnatBeresnev IgnatBeresnev self-requested a review March 13, 2023 12:26
"progress" -> logger.lifecycle(message)
"progress" -> logger.info(message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle's lifecycle level (described as Progress information messages) is the ideal mapping option for Dokka's progress level, so I don't think this change is right, sorry

@IgnatBeresnev
Copy link
Member

Unfortunately, the mentioned problem is not as easy to fix. I might be wrong, but it looks like the proposed solution would silence Dokka overall, no messages will be emitted other than warnings and errors, so for the users it'll look like Dokka is broken all of a sudden.

A proper solution would require revisiting all messages that are logged by Dokka on all levels, and it's also not as easy to decide which messages need to be re-written, which need another level and so on.

If you really want to help with it, it'll take time and we'll need to agree on the messages beforehand so that you don't waste time implementing something we wouldn't be able to accept. Either way, I'll close this PR as it's not really addressing the problem, and we can contibue the discussion on what needs to be done in the issue itself

Thank you for wanting to contribute though, we appreciate it

@eirnym
Copy link
Author

eirnym commented Jul 4, 2024

I haven't touch warnings and errors, also --info flag will output all messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silence logging when running dokkaHtml
2 participants