Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excessive constructor keyword rendered in class signatures #3426

Closed
IgnatBeresnev opened this issue Dec 20, 2023 · 1 comment · Fixed by #3523
Closed

Excessive constructor keyword rendered in class signatures #3426

IgnatBeresnev opened this issue Dec 20, 2023 · 1 comment · Fixed by #3523
Assignees
@whyoleg
Labels
bug topic: stdlib migration An issue/PR related to the migration of stdlib's API reference to modern Dokka
Milestone
Dokka 2.0.0

Comments

@IgnatBeresnev
Copy link
Member

The constructor keyword is in some cases rendered excessively as it's public and doesn't have any parameters.

image
@IgnatBeresnev IgnatBeresnev added bug topic: stdlib migration An issue/PR related to the migration of stdlib's API reference to modern Dokka labels Dec 20, 2023
@IgnatBeresnev IgnatBeresnev added this to the Dokka 2.0.0 milestone Dec 20, 2023
@IgnatBeresnev
Copy link
Member Author

This piece of code might be the reason.

If the primary constructor has an annotation, it renders the "constructor" keyword, even if all the annotations are ignored and are not rendered (i.e annotationsInline() adds nothing). And then it adds parentheses only if there are parameters, which there aren't in this case, so it's just a lonely "constructor" keyword

@whyoleg whyoleg self-assigned this Mar 7, 2024
@whyoleg whyoleg mentioned this issue Mar 8, 2024
Merged
whyoleg added a commit that referenced this issue Mar 14, 2024
@whyoleg
Fix checking for annotations when rendering constructor keyword (#3523)
bc58001 
Fixes #3426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whyoleg whyoleg

Labels
bug topic: stdlib migration An issue/PR related to the migration of stdlib's API reference to modern Dokka
Projects
None yet
Milestone
Dokka 2.0.0
Development

Successfully merging a pull request may close this issue.

Fix checking for annotations when rendering constructor keyword Kotlin/dokka
2 participants
@IgnatBeresnev @whyoleg