fix: simplified markup for external link icon #3260

Kotlin · Jan 15, 2024 · 199954c · 199954c
1 parent 80760e0
commit 199954c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/dokka-subprojects/plugin-base/src/main/resources/dokka/styles/style.css b/dokka-subprojects/plugin-base/src/main/resources/dokka/styles/style.css
@@ -1470,11 +1470,12 @@ div.runnablesample {
 
 .footer--link {
     display: inline-flex;
-    align-items: center; ;
+    align-items: center;
     color: var(--breadcrumb-font-color);
 }
 
-.footer--external-link-icon {
+.footer--link_external:after {
+    content: '';
     width: 12px;
     height: 12px;
     margin-left: 4px;

diff --git a/dokka-subprojects/plugin-base/src/main/resources/dokka/templates/includes/footer.ftl b/dokka-subprojects/plugin-base/src/main/resources/dokka/templates/includes/footer.ftl
@@ -4,9 +4,8 @@
         <span>${footerMessage}</span>
         <span class="pull-right">
             <span>Generated by </span>
-            <a class="footer--link" href="https://github.com/Kotlin/dokka">
+            <a class="footer--link footer--link_external" href="https://github.com/Kotlin/dokka">
                 <span>dokka</span>
-                <span class="footer--external-link-icon"></span>
             </a>
         </span>
     </div>

diff --git a/dokka-subprojects/plugin-base/src/test/kotlin/renderers/html/CustomFooterTest.kt b/dokka-subprojects/plugin-base/src/test/kotlin/renderers/html/CustomFooterTest.kt
@@ -28,7 +28,7 @@ class CustomFooterTest : HtmlRenderingOnlyTestBase() {
         renderedContent.match(
             A(),
             Span(Div("Custom message")),
-            Span(Span("Generated by "), A(Span("dokka"), Span()))
+            Span(Span("Generated by "), A(Span("dokka")))
         )
     }
 

diff --git a/dokka-subprojects/plugin-base/src/test/kotlin/renderers/html/FooterMessageTest.kt b/dokka-subprojects/plugin-base/src/test/kotlin/renderers/html/FooterMessageTest.kt
@@ -22,7 +22,7 @@ class FooterMessageTest : HtmlRenderingOnlyTestBase() {
         renderedContent.match(
             A(),
             Span(defaultFooterMessage),
-            Span(Span("Generated by "), A(Span("dokka"), Span()))
+            Span(Span("Generated by "), A(Span("dokka")))
         )
     }