Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to join missing error? #3441

Open
nilshg opened this issue May 22, 2024 · 1 comment
Open

Add options to join missing error? #3441

nilshg opened this issue May 22, 2024 · 1 comment
Milestone

Comments

@nilshg
Copy link
Contributor

nilshg commented May 22, 2024

Currently we have an ArgumentError when matchmissing==:error and there are missings. Almost every time I run into this I have to look up what the other options are called. Could we change the error from:

ArgumentError: Missing values in key columns are not allowed when matchmissing == :error. `missing` found in column :x in left data frame. 

to:

ArgumentError: Missing values in key columns are not allowed when matchmissing == :error. `missing` found in column :x in left data frame. To perform a join with missing values choose `matchmissing = :equal` or `:notequal`. 

or similar?

@bkamins bkamins added this to the 1.7 milestone May 26, 2024
@bkamins
Copy link
Member

bkamins commented May 26, 2024

Sure - I will add it

@bkamins bkamins modified the milestones: 1.7, 1.x Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants