Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to stop the blinking animation around editable area #312

Closed
Hoiy opened this issue Sep 20, 2016 · 2 comments
Closed

Unable to stop the blinking animation around editable area #312

Hoiy opened this issue Sep 20, 2016 · 2 comments
Milestone

Comments

@Hoiy
Copy link

Hoiy commented Sep 20, 2016

To reproduce the issue, I am using a mac with chrome.

  1. Visit http://getcontenttools.com/demo
  2. Enter edit mode by clicking the pencil button
  3. cmd + shift + 4 to trigger the blinking animation around editable area.
  4. Not sure how to turn off the animation

screen shot 2016-09-20 at 5 51 08 pm

@anthonyjb
Copy link
Member

Hi @Hoiy, just hitting the shift key again should stop it. Not sure why it stayed on, basically when you hold down shift for a couple of sections the editable regions on the page are highlighted so you can see what can be changed, if something prevents the page from registering that the shift key has been released (I'm assuming you released it) then the animation continues.

Sounds like I need to put something in to prevent the animation being triggered if cmd is down as well, flagging as a minor bug.

@Hoiy
Copy link
Author

Hoiy commented Sep 21, 2016

@anthonyjb aw I see. I didn't realize that I could use shift key to disable it. And yes, the animation would stay if you press cmd + shift + 4 (and release) on a mac which is used to capture screenshot.

@anthonyjb anthonyjb added this to the 1.3.1 milestone Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants