-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FontAwesomeIconProps exportable #489
Comments
Hi @michaelcozzolino --- Can you give an example of what you are trying to do and/or how you would use this? |
@jasonlundien
|
Fix is in new release (3.0.6). Added you as a contribute for this as well, thanks for the headsup, patience, and support !!! Let us know if anything else pops up. |
Hm. I've now got the following error:
With v3.0.5, this had worked. That doesn't make much sense, as you just added the exports to 3.0.6. Maybe TypeScript implicitly exports all interfaces from |
This seems to explain it: microsoft/TypeScript#38592 (comment). @jasonlundien, would you mind adding some additional exports? -interface FontAwesomeIconProps {
+export interface FontAwesomeIconProps {
...
-interface FontAwesomeLayersProps {
+export interface FontAwesomeLayersProps {
...
-interface FontAwesomeLayersTextProps {
+export interface FontAwesomeLayersTextProps {
... |
@jasonlundien 5ce88a7#diff-7aa4473ede4abd9ec099e87fec67fd57afafaf39e05d493ab4533acc38547eb8R47 |
Hey @dmke --- Can you give us an example of what you are doing / how you are using it when you see the error above ? |
@jasonlundien, sure: I've got a helper method to condense The code looks like this:
|
Facing the same issue currently. Previously I was able to import everything from the index.d.ts file, however now I'm unable to import anything that is not present in the export definition. I was able to work around this by getting the type of the props using the following TypeScript magic:
However this is far from ideal. |
This should be good now, Let us know if anything else pops up. |
Can confirm, 3.0.8 exports |
Currently in index.d.ts FontAwesomeIconProps is not exported. I cannot build a wrapper using some or all of the props. is it possible to have it exported?
The text was updated successfully, but these errors were encountered: