Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ariaLabel renders with both aria-hidden and aria-label #126

Open
ellucianBret opened this issue May 2, 2018 · 3 comments
Open

ariaLabel renders with both aria-hidden and aria-label #126

ellucianBret opened this issue May 2, 2018 · 3 comments
Labels

Comments

@ellucianBret
Copy link

This would mean the aria-label would be ignored by screen readers!

If ariaLabel is passed as a property it should not add the aria-hidden="true"

@getricj
Copy link

getricj commented Jul 13, 2018

I too have come across this issue I had to explicitly add aria-hidden="false" to stop this from happening.

@James-Reed-cognito
Copy link

James-Reed-cognito commented Dec 2, 2020

I have just come across this issue myself and it still persists in Dec 2020 :) using

"@fortawesome/fontawesome-svg-core": "^1.2.32",
    "@fortawesome/free-solid-svg-icons": "^5.15.1",
    "@fortawesome/react-fontawesome": "^0.1.13",```

repro case here https://codesandbox.io/s/elated-sea-2ly3w

It seems very odd that we have to manually make sure that aria-hidden is set to false when the icons are obviously showing. @robmadole has anyone from FortAwesome looked at this since the label was added?

@taradevries
Copy link

Bumping this because I also find it silly to manually set aria-hidden to false if an aria-label is provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants