Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked Icon Helper #59

Open
jtrost opened this issue Oct 27, 2014 · 4 comments
Open

Stacked Icon Helper #59

jtrost opened this issue Oct 27, 2014 · 4 comments

Comments

@jtrost
Copy link

jtrost commented Oct 27, 2014

There should be a helper for stacked icons. Using the example from: http://fortawesome.github.io/Font-Awesome/examples/#stacked

<span class="fa-stack fa-lg">
  <i class="fa fa-camera fa-stack-1x"></i>
  <i class="fa fa-ban fa-stack-2x text-danger"></i>
</span>

Right now this could be implemented using the icon helper like this:

<span class="fa-stack fa-lg">
  <%= icon("camera", "", class: "fa-stack-1x") %>
  <%= icon("ban", "", class: "fa-stack-2x text-danger") %>
</span>

I think there should be a helper specifically for stacked icons. It could be written like this:

<%= stacked_icon(
  icon("camera", "", class: "fa-stack-1x"), # The first icon to stack
  icon("ban", "", class: "fa-stack-2x text-danger"), # The second icon to stack
  class: "fa-lg" # Additional classes for fa-stack
) %>
@excid3
Copy link

excid3 commented Nov 2, 2014

👍

@jtrost
Copy link
Author

jtrost commented Jan 31, 2015

@excid3 There hasn't been any movement on this, so I created pull request #71 with the stacked_icon helper.

@maahd
Copy link

maahd commented Nov 9, 2015

+1

@joaolucasl
Copy link

+1! This would be a great feature to have available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants