-
Notifications
You must be signed in to change notification settings - Fork 49
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0: 'faCheck' is not exported by node_modules/@fortawesome/free-solid-svg-icons/index.js #230
Comments
Friendly ping to @robmadole - might need some patch releases...
|
As with the OP, I am also running this with From what I can tell, we need the exports to be listed in the package.json files of the icon packages. It's given in v6 but not v5 The broccoli-rollup PR author mentions this too. I hope this gives enough to go on |
Ok, I'll take another look at this as soon as I can. Thanks, all. |
Alright folks. I've just released 0.4.3 and I think it contains the updates that I missed in 0.4.2. If anyone has time to test it and let me know that would be appreciated. Thanks @Techn1x for the oversight. |
Thanks for that release - do you know who would be best to ping about updating the v5 icon packages to work with broccoli-rollup v5 ? |
@Techn1x thats us! We are only updating the 5.x line for security patches though so that fix won't get prioritized. We're recommending everyone upgrade to major version 6. |
Website would disagree with you there.. might want to update it if that's the case.
Of course. But I guess anyone on the v5 icon set won't get to be able to be use ember-fontawesome v1 "stable", which is a bit rough. Was only a year and a bit ago when v6 icons weren't even released yet. I understand old releases can't be maintained forever, but I did expect a little higher out of an LTS for an icon set where updating changes the look and feel of a website. It does shine a light on the fact that a downside of using an icon framework like this means the icons are going to change else the code will be left behind. I also wonder if react-fontawesome still works with the v5 icon set... |
@robmadole Build Error (pro-solid-svg-icons-rollup)
'faAngleRight' is not exported by ../../../../home/myuser/projects/my-project/node_modules/@fortawesome/pro-solid-svg-icons/index.js, imported by exports-pro-solid-svg-icons.js For me FA5 is also still a LTS Version.. also in the download-Page there is written, so i think, that this packages should also support FA5. |
@robmadole Believe me, I would love to upgrade to version 6 so much, but at the current stage some (especially duotone) icons are in, it is pretty much impossible to do so without confusing our users. For instance, this is used to be an envelope, but it now just looks like an odd geometrical shape. Could you please either fix v6, or continue to maintain v5? That would be super awesome. Thank you. Another alternative probably would be to implement #195 and allow users to create kits that mix v5 and v6 icons, so we can keep the v5 icons that are better quality than v6 icons. But that probably would still mean to continue to support v5. |
Fair point. We either need to stand by that or change it. We'll give this some thought.
We haven't thought of it from this point of view much. The idea that changing the look of the icon is considered a major change is a bit of a surprise. This is probably because of internal bias (6 is better!) and underestimating how much some of the icons have changed (as @st-h has mentioned).
I was not aware! That changes some of my thinking on this. I'll need to think through these points. Thanks everyone for spending the time. I'll comment back here when we make a decision. |
Hi @robmadole - any update on this ?
Answering my own question - it does seem to build with v5 icon set. Ideally ember-fontawesome shouldn't be any different.. |
The best way to maintain support for v5 icons is to pin this add-on at |
EDIT: looks like there has been movement on keeping FA5 working 🎉 Will leave my original comment as is, below Pinning this addon to 0.4.2 with its ancient versions of dependencies forever is exactly what I want to avoid.. Disappointing but I've already made my case and I'll that's all I can do I don't really see the problem as being ember-fontawesome here - it didn't/doesn't promise any kind of LTS and wasn't a stable 1.0 version yet. But rather the FA v5 LTS icon set does promise quality of life fixes / patch updates - IMO the fix needed here would be exactly that. I am guessing it must be a huge PITA to fix given that maintainers seem to be against it. Might want to update the readme and github about sections for its various references to FA 5 (and even 4)..
It would be extra kind to consumers to update the changelog too with the now-known breaking changes ❤️ |
Describe the bug
Upgrade ember-fonteawesome to 1.0.0 together with
@fortawesome/free-solid-svg-icons: 5.15.4
and an icon.js config.When running an ember 4.12.0 app, the following error is printed:
Rolling back to 0.4.2 and everything works fine again. However, the changelog says that there were no changes between 0.4.2 and 1.0.0 🤷♀️ I have deleted my node_modules folder, to make sure this is not a local issue, but the issue persists repeatedly.
yarn version: 1.22.19
Expected behavior
The app still boots up after upgrading to v1.0.0.
The text was updated successfully, but these errors were encountered: