You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When you install @fortawesome/ember-fontawesome": "^0.4.0" and do an ember build --prod, the output file vendor....js in dist folder contains the absolute path to another package (ember-get-config).
Reproducible test case
Here I've created a repo where the issue can be reproduced easily fa-test. If you want you can directly examine the vendor file.
Or get the repo, and do npm install and examine vendor...js file in dist folder, you should see an absolute path to one of the packages in your local machine.
Expected behavior
We want deterministic builds that are absolute-path invariant (i.e. the build output shouldn't depend on the machine or the location of the project in the file system). Sometimes we build on our local machine, but sometimes the build is done in some agent (CI/CD Azure for example). We want build outputs to be identical no matter the machine that they are built on.
This is a regression issue, it wasn't presented earlier @fortawesome/ember-fontawesome": "^0.2.3" version that we used.
Desktop (please complete the following information):
Browser: Chrome
Version: 104.0.5112.81 (Official Build) (64-bit)
Additional context
Please check the ReadMe file for more instructions about this issue.
The text was updated successfully, but these errors were encountered:
Thanks for the report! That indeed looks like a bug. Please report this to ember-get-config as I don't think it is a problem specific ember-fontawesom. If I'm wrong about this or not understanding how we could fix it here feel free to re-open this ticket here.
Describe the bug
When you install
@fortawesome/ember-fontawesome": "^0.4.0"
and do anember build --prod
, the output filevendor....js
indist
folder contains the absolute path to another package (ember-get-config
).Reproducible test case
Here I've created a repo where the issue can be reproduced easily fa-test. If you want you can directly examine the vendor file.
Or get the repo, and do
npm install
and examinevendor...js
file indist
folder, you should see an absolute path to one of the packages in your local machine.Expected behavior
We want deterministic builds that are absolute-path invariant (i.e. the build output shouldn't depend on the machine or the location of the project in the file system). Sometimes we build on our local machine, but sometimes the build is done in some agent (CI/CD Azure for example). We want build outputs to be identical no matter the machine that they are built on.
This is a regression issue, it wasn't presented earlier
@fortawesome/ember-fontawesome": "^0.2.3"
version that we used.Desktop (please complete the following information):
Additional context
Please check the ReadMe file for more instructions about this issue.
The text was updated successfully, but these errors were encountered: