Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme example not working #108

Closed
maxwondercorn opened this issue Jun 1, 2019 · 2 comments
Closed

Readme example not working #108

maxwondercorn opened this issue Jun 1, 2019 · 2 comments

Comments

@maxwondercorn
Copy link

I was creating a PR to document the new Ember angle bracket component syntax and found that this example in the readme does not render correctly

<span class="fa-layers fa-lg">
  {{fa-icon 'circle'}}
  {{fa-icon class='fa-inverse check' transform='shrink-6'}}
</span>

The circle renders, the check does not. I though maybe the fa-inverse class should have been in a <span></span> surrounding {{fa-icon 'check'}} but that doesn't work either.

Not that is should make a difference but I'm only using the pro icon sets

@st-h
Copy link
Contributor

st-h commented Jun 3, 2019

@maxwondercorn I think the issue is that the second {{fa-icon ...}} is missing the icon name check, but is used to add a class. This seems to work (as long as your current color is not white):

<span class="fa-layers fa-lg">
  {{fa-icon 'circle'}}
  {{fa-icon 'check' class='fa-inverse' transform='shrink-6'}}
</span>

@maxwondercorn
Copy link
Author

Thanks - that couldn't have been more obvious. I'll fix the example in the PR I created for angle brackets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants