Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Replace margin-left/margin-right in favor of direction neutral RTL-friendly margin-inset-start/end #20305

Open
2 tasks done
matsbryntse opened this issue Jul 22, 2024 · 0 comments
Labels
bug needs-triage This bug needs to be confirmed

Comments

@matsbryntse
Copy link

matsbryntse commented Jul 22, 2024

Bug description

Seeing a few places which can be modernized:

.#{$fa-css-prefix}-ul {
  list-style-type: none;
  margin-left: var(--#{$fa-css-prefix}-li-margin, #{$fa-li-margin});
  margin-inline-start: var(--#{$fa-css-prefix}-li-margin, #{$fa-li-margin});

Reproducible test case

No response

Screenshots

No response

Font Awesome version

6.6

Serving

Self-hosted

Implementation

CSS

Browser and Operating System

Mac OS Ventura

Web bug report checklist

  • I have included a test case because my odds go way up that the team can fix this when I do
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
@matsbryntse matsbryntse added bug needs-triage This bug needs to be confirmed labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-triage This bug needs to be confirmed
Projects
None yet
Development

No branches or pull requests

1 participant