Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai: better error messages; fix greedy matching #2327

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

baberabb
Copy link
Contributor

@baberabb baberabb commented Sep 20, 2024

closes #2326, closes #2318, closes #2287

@baberabb baberabb marked this pull request as ready for review September 20, 2024 07:38
Copy link
Collaborator

@haileyschoelkopf haileyschoelkopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a couple nits

lm_eval/models/openai_completions.py Outdated Show resolved Hide resolved
lm_eval/models/openai_completions.py Outdated Show resolved Hide resolved
baberabb and others added 3 commits September 27, 2024 00:18
Co-authored-by: Hailey Schoelkopf <65563625+haileyschoelkopf@users.noreply.github.com>
Co-authored-by: Hailey Schoelkopf <65563625+haileyschoelkopf@users.noreply.github.com>
@baberabb
Copy link
Contributor Author

@haileyschoelkopf add your suggestions! thanks

Copy link
Collaborator

@haileyschoelkopf haileyschoelkopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as test failure is unrelated!

Any clue what the new test failure is due to at a glance? nw if not

@haileyschoelkopf haileyschoelkopf merged commit 1bc6c93 into main Sep 26, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants