Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Dialog: typo for the "type" property #3369

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

shmolf
Copy link
Contributor

@shmolf shmolf commented Nov 20, 2019

Description

Fixes a typo, for OS confirmation dialogue types.

When permanently deleting a note, or when deleting a tag, a warning dialogue should be presented. But with the type of ype instead of type, a generic dialogue is presented.

Current behavior:
boostnote-pre-fix
boostnote-tag-pre-fix

Expected Behavior:
boostnote-tag-post-fix
boostnote-post-fix

Issue fixed

No issues currently exist that identify the issue.

I could not replicate #2944, but the OS might be treating generic dialogues differently than warnings.

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added the approved 👍 Pull request has been approved by sufficient reviewers. label Nov 20, 2019
@Rokt33r Rokt33r added this to the v0.14.0 milestone Nov 21, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Nov 21, 2019
@Rokt33r Rokt33r merged commit 9530054 into BoostIO:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants