Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chinese translation #3219

Merged
merged 5 commits into from
Sep 2, 2019
Merged

Update Chinese translation #3219

merged 5 commits into from
Sep 2, 2019

Conversation

minbaby
Copy link
Contributor

@minbaby minbaby commented Aug 22, 2019

Description

Before
image

After
image

Update Chinese translation.

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! label Aug 25, 2019
@ZeroX-DG
Copy link
Member

@minbaby Do you have someone else to review this PR before we merge this?

@minbaby
Copy link
Contributor Author

minbaby commented Aug 26, 2019

No, recommend someone please.

hikerpig
hikerpig suggested changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@hikerpig hikerpig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Some translations could be more precise.
  2. Some irrelevant diffs are caused by tab->space softtabstop, are there any rules about tab/space indent? I my opinion, it' better to use tabs to be in accordance with other translation files.

locales/zh-CN.json Outdated Show resolved Hide resolved
locales/zh-CN.json Outdated Show resolved Hide resolved
locales/zh-CN.json Outdated Show resolved Hide resolved
@minbaby
Copy link
Contributor Author

minbaby commented Aug 26, 2019

image

as editorconfig, the IDE auto convert tab to space

@hikerpig
Copy link
Contributor

Translations look good to me.
@ZeroX-DG Should we run a total format on locales/*.json to fit editorconfig?
I will recommend npx prettier locales/*.json --write, in another commit.

@ZeroX-DG
Copy link
Member

Thanks @hikerpig, yes we definitely need to re-format all of them. @minbaby Can you do that in this PR too?

@ZeroX-DG ZeroX-DG added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Aug 27, 2019
@minbaby
Copy link
Contributor Author

minbaby commented Aug 27, 2019

@ZeroX-DG Done, follow @hikerpig command.

ZeroX-DG
ZeroX-DG approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thank you guys for your contributions! 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! labels Aug 28, 2019
@Rokt33r Rokt33r merged commit ff7c449 into BoostIO:master Sep 2, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Sep 2, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikerpig hikerpig hikerpig requested changes

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@minbaby @ZeroX-DG @hikerpig @Rokt33r