Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't apply animation delay for custom layout #558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

0ptim
Copy link
Contributor

@0ptim 0ptim commented Feb 20, 2024

If someone uses UseCustomLayout = true, animations won't be applied.

Because the default animation is ModalAnimationType.FadeInOut, the delay for the animation will be applied also for custom layouts, which leads to a very bad 400ms delay where nothing happens after closing a dialog.

@0ptim
Copy link
Contributor Author

0ptim commented Feb 20, 2024

Forgot to mention: Maybe it's better to just set the animation default to None for custom layouts automatically. But I'm not sure how to best handle this.

@byOsta byOsta mentioned this pull request Feb 20, 2024
@chrissainty chrissainty added the Bug Something isn't working label Feb 20, 2024
Copy link
Member

@chrissainty chrissainty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @0ptim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants