feat(avm)!: GETENVVAR + ISSTATICCALL #8692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @fcarreiro and the rest of your teammates on |
fcarreiro
requested review from
dbanks12,
jeanmon,
IlyasRidhuan and
Maddiaa0
as code owners
dbanks12
approved these changes
Sep 23, 2024
Comment on lines
1796
to
1802
| // TEST_F(AvmExecutionTests, l2GasLeft) | ||
| // { | ||
| // std::string bytecode_hex = to_hex(OpCode::SET_16) + // opcode SET | ||
| // "00" // Indirect flag | ||
| // + to_hex(AvmMemoryTag::U32) + | ||
| // "0101" // val 257 | ||
| // "0011" // dst_offset 17 |
There was a problem hiding this comment.
Why are these commented out?
fcarreiro
force-pushed
the
fc/avm-getenvvar-opcode
branch
2 times, most recently
from
11f5fdf
to
1d121bc
Compare
Merge activity
|
fcarreiro
force-pushed
the
fc/avm-getenvvar-opcode
branch
from
a896dc5
to
8725339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason I'm keeping all the oracles on the Noir side, is because I need to pass the enum index as an immediate and Noir doesn't allow that in any other way. That is, if you had an oracle
get_env_var(var_idx: u8), when you call it likeget_env_var(12)you would get a memory address with the 12 in it; and not the12constant.