Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Benchmark compute_row_evaluations and update analysis script #8673

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

codygunton
Copy link
Contributor

@codygunton codygunton commented Sep 20, 2024

Adds a bench and updates the CIVC benchmark analysis script to use the new name for Oink part of the Pg prover.

Benchmark results:

Benchmarking lock created at ~/BENCHMARK_IN_PROGRESS.
protogalaxy_bench                                                            100% 5225KB  24.6MB/s   00:00    
2024-09-20T20:16:15+00:00
Running ./protogalaxy_bench
Run on (16 X 3000 MHz CPU s)
CPU Caches:
  L1 Data 32 KiB (x8)
  L1 Instruction 32 KiB (x8)
  L2 Unified 1024 KiB (x8)
  L3 Unified 36608 KiB (x1)
Load Average: 0.08, 0.06, 0.34
---------------------------------------------------------------------
Benchmark                           Time             CPU   Iterations
---------------------------------------------------------------------
compute_row_evaluations/15       6.59 ms         6.51 ms          107
compute_row_evaluations/16       13.4 ms         13.4 ms           52
compute_row_evaluations/17       27.0 ms         26.9 ms           26
compute_row_evaluations/18       54.8 ms         54.6 ms           12
compute_row_evaluations/19        112 ms          112 ms            6
compute_row_evaluations/20        233 ms          232 ms            3
compute_row_evaluations/21        462 ms          461 ms            2

@codygunton codygunton self-assigned this Sep 20, 2024
@maramihali maramihali self-requested a review September 23, 2024 14:25
Copy link
Contributor

@maramihali maramihali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix typos!

using FF = typename Flavor::FF;

/**
* @brief As expected, this is about NUM_SUBRELAITONSS (40ish) * cost of FF alloc (33ms at size 2^21)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @brief As expected, this is about NUM_SUBRELAITONSS (40ish) * cost of FF alloc (33ms at size 2^21)
* @brief As expected, this is about NUM_SUBRELAITONS (40ish) * cost of FF alloc (33ms at size 2^21)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a typo in your typo fix :D

}

/**
* @brief As expected, this is about NUM_SUBRELAITONSS (40ish) * cost of FF alloc (33ms at size 2^21)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @brief As expected, this is about NUM_SUBRELAITONSS (40ish) * cost of FF alloc (33ms at size 2^21)
* @brief As expected, this is about NUM_SUBRELAITONS (40ish) * cost of FF alloc (33ms at size 2^21)

/**
* @brief As expected, this is about NUM_SUBRELAITONSS (40ish) * cost of FF alloc (33ms at size 2^21)
*
* @param state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment or remove?

@codygunton codygunton merged commit c738c47 into master Sep 23, 2024
36 checks passed
@codygunton codygunton deleted the cg/compute_row_evaluations_bench branch September 23, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants