-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Benchmark compute_row_evaluations and update analysis script #8673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix typos!
using FF = typename Flavor::FF; | ||
|
||
/** | ||
* @brief As expected, this is about NUM_SUBRELAITONSS (40ish) * cost of FF alloc (33ms at size 2^21) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @brief As expected, this is about NUM_SUBRELAITONSS (40ish) * cost of FF alloc (33ms at size 2^21) | |
* @brief As expected, this is about NUM_SUBRELAITONS (40ish) * cost of FF alloc (33ms at size 2^21) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a typo in your typo fix :D
} | ||
|
||
/** | ||
* @brief As expected, this is about NUM_SUBRELAITONSS (40ish) * cost of FF alloc (33ms at size 2^21) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @brief As expected, this is about NUM_SUBRELAITONSS (40ish) * cost of FF alloc (33ms at size 2^21) | |
* @brief As expected, this is about NUM_SUBRELAITONS (40ish) * cost of FF alloc (33ms at size 2^21) |
/** | ||
* @brief As expected, this is about NUM_SUBRELAITONSS (40ish) * cost of FF alloc (33ms at size 2^21) | ||
* | ||
* @param state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment or remove?
Adds a bench and updates the CIVC benchmark analysis script to use the new name for Oink part of the Pg prover.
Benchmark results: