feat: add validation to request / response interactions + adjust scoring appropiately #8641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
just-mitch
approved these changes
Sep 20, 2024
| return false; | ||
| } | ||
|
|
||
| if (!requestedTxHash.equals(responseTx.getTxHash())) { |
There was a problem hiding this comment.
should we be performing this check first? Should be a faster filter than verifying the proof right?
| @@ -209,5 +229,47 @@ describe('ReqResp', () => { | |||
|
|
|||
| await stopNodes(nodes); | |||
| }); | |||
|
|
|||
| it('Should penalize peer if transaction validation fails', async () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a request response validator to the request response module that will make sure the data
returned from the reqresp request is the data that has been requested.
In the Transaction case, this means verifying the proof to ensure that the first nullifier is actually correct.
We do not use the tx propagation validator as it performs more checks than required. If we are requesting a transaction, it is either during a sync, or for an performing attestation, where we do not care about being served old data. Just data that is what we asked for
fixes: #8483
fixes: #8485